<jtojnar> welcome maxine
<jtojnar> I have opened https://github.com/NixOS/nixpkgs/pull/117081 so testing packages, sending fixup commits against the branch or reading changelogs and pointing out problems would be nice
<piegames[m]> maxine (IRC): I'll add a shamless plug to my pull request as well :p https://github.com/NixOS/nixpkgs/pull/108414
<piegames[m]> Btw jtojnar (IRC) it would be great to have a "go" from you on this as well
<maxine> jtojnar: neat! I have a branch with fixes for building some gnome stuff, so I'll rebase and send those.
<maxine> jtojnar: cause I don't wanna make too many dirty commits, how would you prefer I do fixups of package bumps? fixup followed by a fresh commit, or keep them all as fixups?
<jtojnar> maxine: either fixup + fresh or single squash
<jtojnar> though we will probably need to tweak the commit messages in the end when squashing 3:38→rc + rc→40
<jtojnar> will probably have to create a script to combine the commit messages when rebasing
<jtojnar> so some format that can be resolved automatically would be for the best
<maxine> Ah, dang, only with this did I notice you use fancy arrows and not ->
<maxine> Most of my fixups change versions already so those will need message changes...
<maxine> piegames[m]: tbh I don't see what I can review there 😅, I avoid python outside of work at all opportunities - any concerns I could have (e.g. needing to patch extensions to get them working on nix, like unite or no-title-bar needing path patches) seem to have been covered by all previous reviews
<piegames[m]> maxine (IRC): Sorry, I forgot to write a few words on this. The PR is pretty mature already, the best thing you can do is to try it out and see if some things break.
<piegames[m]> On the other hand, I've already thought "I'm done" quite a few times now, and then somebody came around the corner with some major valid concerns and I was back to square one …