<samueldr>
I'd prefer if it elegantly knew the test isn't available :/
<samueldr>
though I'm not 100% confident I understand the intention behind all the "all"
<samueldr>
I think it's right that it fails if the attribute for $desired_platform isn't available, otherwise something could vanish and eval of release-combined wouldn't fail
<{^_^}>
#50596 (by svanderburg, 4 weeks ago, open): Mobile updates
<__Sander__>
reason is that we implemented a function that requires someone to accept the license of the Android SDK first
<__Sander__>
as a result, the evaluation fails
<__Sander__>
if I integrate this PR, will this become a problem for future evaluations?
qyliss has quit [Quit: bye]
qyliss^work has quit [Quit: bye]
harrow has joined #nixos-dev
<gchristensen>
yes, a red X always mens never merge
<gchristensen>
__Sander__: I'm not sure why this requires special license code, beyond the addition of a new license to licenses.nix and the normal handling?
<__Sander__>
gchristensen: it's because you need to accept the Android EULA
<__Sander__>
without it you can't use it unfortunately
qyliss has joined #nixos-dev
qyliss^work has joined #nixos-dev
<__Sander__>
the weird thing is. this particular feature already existed before the merge
<__Sander__>
I just simply ported that feature
<gchristensen>
I think we handle this with oracle's java with requireFile
<gchristensen>
so in order to actually fetch the source, they must accept the eula, but also we stick to the standard licenseing tooling
<__Sander__>
gchristensen: difficulty is that the Android SDK is not a single file but an entire set of plugins
<gchristensen>
aye, that is hard
<__Sander__>
but
<__Sander__>
even if I implement such an approach
<__Sander__>
the evaluation is failed because of the program.adb NixOS module
<__Sander__>
which makes a reference to Android platform tools, but that evaluation will fail
<gchristensen>
no, it will evaluate fine
<gchristensen>
but it won't build -- this is fine
<gchristensen>
I think the source of the problem is using relatedPackages
<__Sander__>
hmm
<gchristensen>
try removing those?
<__Sander__>
hmm maybe I should try that
<gchristensen>
relatedPackgaes knows how to handle license problems
<gchristensen>
I think it is not nice that this uses its own licensing code :/
<gchristensen>
but I see the problem and I don't know a solution
<__Sander__>
maybe I need to change something in the Android packages generator
<__Sander__>
to always blacklist the tools package or something with requireFile
<gchristensen>
back in about 2hrs
<__Sander__>
ok
orivej has joined #nixos-dev
<janneke>
o/
<Synthetica>
__Sander__: on some CI platforms, you can automatically accept android license agreements, maybe look into how they are doing that
<__Sander__>
I know that apt/dpkg has a feature to display a license agreement and asking the user for confirmation
<__Sander__>
unfortunately, such a feature does not exists in Nix yet
<domenkozar>
iirc nix by design doesn't block on user input
drakonis has quit [Ping timeout: 268 seconds]
orivej has quit [Ping timeout: 250 seconds]
<samueldr>
for some non-redistributable things I think we're assuming that once it's in the store, the user agreed to the license (via prefetch) maybe the same could be done with either the source or the body of their license?
<samueldr>
(I'm thinking about virtualbox here)
<samueldr>
oh, I see this was talked about already (with java's eula)
orivej has joined #nixos-dev
jtojnar has joined #nixos-dev
<qyliss^work>
Are there criteria for when I should self-merge without a review? Eg, I've seen that simple package upgrades are usually okay, but I'm wondering about https://github.com/NixOS/nixpkgs/pull/52416, which is technically a new package, and has sat for a few days with no comments.
<{^_^}>
#52416 (by alyssais, 3 days ago, open): icu63: init at 63.1
pie___ has joined #nixos-dev
pie__ has quit [Remote host closed the connection]
<bennofs[m]>
qyliss^work: aren't new packages even less critical than updates? nothing that could break really if you merge it
<qyliss>
I guess that’s one way of looking at it!
<qyliss>
otoh, new packages are more subjective and potentially more stuff to argue about, and usually more code
<samueldr>
hi, there's #52534 on which I'd like some feedback, ideally before the week-end; I would merge and watch hydra to fix any issues it causes
__Sander__ has quit [Quit: Konversation terminated!]
orivej has quit [Ping timeout: 240 seconds]
drakonis has joined #nixos-dev
drakonis has quit [Read error: Connection reset by peer]
__Sander__ has joined #nixos-dev
<__Sander__>
gchristensen: removing adb from relatedPackages seemed to do the trick
<__Sander__>
status is green now
<gchristensen>
great
Synthetica has quit [Quit: Connection closed for inactivity]
<__Sander__>
this relatedPackages property scares me a bit, but I guess that's a different discussion
<__Sander__>
anyway, the Android SDK pull request is now mergeable
Synthetica has joined #nixos-dev
apaul1729 has joined #nixos-dev
<timokau[m]>
I'd again like to push re-enabling email notifications on hydra. The latest staging merge introduced some failures and I only noticed them because I made it a habit to regularly check some of my packages manually. Even thought about writing a script to parse the hydra html page, but that seems backwards.
<dtz>
CI is so much less useful --especially on the scale of the NixOS/nixpkgs package set-- if you have to check it vs it yells at you
fadenb has quit [Remote host closed the connection]
<timokau[m]>
Who actually has the permissions to change the hydra configuration?
<gchristensen>
timokau[m]: well, there are a few people who have access to change the configuration, but I think we would all defer to niksnut to make this change
fadenb has joined #nixos-dev
<gchristensen>
I've been chatting with him about that change today ... but it got a bit interrupted by a sour DNS update
fadenb has quit [Client Quit]
fadenb has joined #nixos-dev
fadenb has quit [Client Quit]
<timokau[m]>
Good to know its at least on the radar :) Although I wish he'd voice his objections in the issue discussion
fadenb has joined #nixos-dev
contrapumpkin has joined #nixos-dev
copumpkin has quit [Ping timeout: 268 seconds]
orivej has joined #nixos-dev
orivej has quit [Remote host closed the connection]
phreedom has quit [Remote host closed the connection]
phreedom has joined #nixos-dev
sir_guy_carleton has joined #nixos-dev
orivej has joined #nixos-dev
__Sander__ has quit [Quit: Konversation terminated!]
apaul1729 has quit [Remote host closed the connection]