<Sonarpulse>
bgamari: you might not have commit access yet (at least you didn't show up on the reviewers list of github's), but at this point I think you are the best prepared to review this :)
jtojnar has joined joined #nixos-dev
jtojnar has quit [(Read error: Connection reset by peer)]
<bgamari>
Sonarpulse, cool, I'll have a look
jtojnar has joined joined #nixos-dev
jtojnar has quit [(Read error: Connection reset by peer)]
jtojnar has joined joined #nixos-dev
<Sonarpulse>
bgamari: among other reasons, cause you've rebased it :D
<Sonarpulse>
good night everyone!
jtojnar has quit [(Read error: Connection reset by peer)]
<bgamari>
cheers!
Sonarpulse has quit [(Ping timeout: 248 seconds)]
pie_ has quit [(Remote host closed the connection)]
pie_ has joined joined #nixos-dev
yegortimoshenko has quit [(Ping timeout: 256 seconds)]
pie_ has quit [(Ping timeout: 265 seconds)]
phreedom has joined joined #nixos-dev
jtojnar has joined joined #nixos-dev
ma27 has joined joined #nixos-dev
jtojnar has quit [(Ping timeout: 272 seconds)]
jtojnar has joined joined #nixos-dev
jtojnar has quit [(Ping timeout: 252 seconds)]
jtojnar has joined joined #nixos-dev
ma27 has quit [(Ping timeout: 265 seconds)]
phreedom has quit [(Ping timeout: 240 seconds)]
orivej has quit [(Ping timeout: 272 seconds)]
phreedom has joined joined #nixos-dev
jtojnar has quit [(Quit: jtojnar)]
ma27 has joined joined #nixos-dev
romildo has joined joined #nixos-dev
fpletz has quit [(Ping timeout: 252 seconds)]
fpletz has joined joined #nixos-dev
ma27 has quit [(Ping timeout: 272 seconds)]
ma27 has joined joined #nixos-dev
LnL7 has joined joined #nixos-dev
LnL has quit [(Ping timeout: 260 seconds)]
<domenkozar>
while setting up the build environment: executing ‘/nix/store/y6mfysf2w7yx30bfyp9qk9br29qccwlw-bash-4.4-p12/bin/bash’: No such file or directory
<domenkozar>
this is new
<domenkozar>
ah!
<domenkozar>
fixed nixpkgs pinning doesn't depend on it
<gchristensen>
^ I'm adding a restart-jobs role so we can grant this privilege to users who are known to the community and want to help, but aren't long-time memberswho we don't want to give full Admin access
ma27 has quit [(Ping timeout: 272 seconds)]
ma27 has joined joined #nixos-dev
pie_ has joined joined #nixos-dev
pie_ has quit [(Ping timeout: 265 seconds)]
taktoa has joined joined #nixos-dev
pie_ has joined joined #nixos-dev
pie_ has quit [(Ping timeout: 250 seconds)]
ma27 has quit [(Ping timeout: 265 seconds)]
pie_ has joined joined #nixos-dev
ma27 has joined joined #nixos-dev
zarel has joined joined #nixos-dev
yegortimoshenko has joined joined #nixos-dev
zarel has quit [(Ping timeout: 264 seconds)]
pie_ has quit [(Ping timeout: 246 seconds)]
orivej has joined joined #nixos-dev
pie_ has joined joined #nixos-dev
pie_ has quit [(Ping timeout: 260 seconds)]
ma27 has quit [(Ping timeout: 265 seconds)]
taktoa has quit [(Remote host closed the connection)]
FRidh has quit [(Quit: Konversation terminated!)]
jtojnar has joined joined #nixos-dev
Mic92 has quit [(Ping timeout: 250 seconds)]
JosW has quit [(Quit: Konversation terminated!)]
taktoa has joined joined #nixos-dev
phreedom has quit [(Remote host closed the connection)]
phreedom has joined joined #nixos-dev
phreedom has quit [(Quit: No Ping reply in 180 seconds.)]
phreedom has joined joined #nixos-dev
yegortimoshenko has quit [(Remote host closed the connection)]
<aminechikhaoui>
just added few tests to tests/functional/vpc.py
orivej has quit [(Ping timeout: 256 seconds)]
shlevy has quit [(Ping timeout: 255 seconds)]
shlevy has joined joined #nixos-dev
<domenkozar>
aminechikhaoui: uhh I promised to do so
<domenkozar>
really hard to review such big PRs :)
ma27 has joined joined #nixos-dev
<aminechikhaoui>
domenkozar: yeah, unfortunetly, the best is to experiment with which niksnut did at some point (afaik he's fine with the PR now), or do more coverage with tests but not sure to which level we should test
<aminechikhaoui>
most of the current tests in nixops are pretty basic
Mic92 has joined joined #nixos-dev
taktoa has quit [(Quit: No Ping reply in 180 seconds.)]