gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
orivej has quit [Ping timeout: 244 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 245 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 268 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 246 seconds]
orivej has joined #nixos-borg
<{^_^}> [ofborg] @edef1c opened pull request #288 → Move @edef1c to trusted users → https://git.io/fpHGg
<gchristensen> LnL: ^ feel good about that?
edef has joined #nixos-borg
<edef> gchristensen: i assume you're cool with pulling in chrono for time formatting?
<gchristensen> yeah
<gchristensen> once you do that, you'll need to run ./nix/update-carnix.sh
<gchristensen> which, fingers crossed, does the business (if it doesn't, I can do that sometimes-painful process)
<edef> gchristensen: also, if you're willing to switch to edition = "2018", we can drop `extern crate`
<gchristensen> edef: I'm not sure 2018 is in nixpkgs master yet?
<edef> oh, plausible
<edef> i live on nightlies so i don't really notice nixpkgs master rust state
<gchristensen> it is in staging
<gchristensen> once it hits a channel, I'm +1 for sure
<edef> nixpkgs master appears to have 1.30.1?
<gchristensen> oh cool
<edef> oh it's 1.31 that brings in Rust 2018
<edef> you're right
<edef> brain was like "thirty.. one.. yup that's it"
<gchristensen> oh hehe
<gchristensen> ok, yeah, it'll be here soon though
<gchristensen> btw edef I feel a lot of my Rust isn't excellent, and I'd be happy to make massive changes to its structure to make it nicer.
qyliss^work has joined #nixos-borg
<edef> gchristensen: your use of `extern crate` is somewhat weird
<edef> gchristensen: you have `extern crate` in module files, but then `use` without `self::`
<edef> gchristensen: `use` is relative to crate root
<edef> gchristensen: those extern crates are no-ops
<edef> i'll write a PR to remove them, i guess?
<gchristensen> I'm sure that is weird
<gchristensen> sure, that would be fine (also would be fine if you wanted to wait until 2018 and do it in one fell swoop, doesn't matter to me)
<edef> mm
<qyliss^work> Didn't 2018 come out, like, yesterday? Or was that something else?
<gchristensen> quite recently
<edef> on the 6th
<edef> i'm shockingly unaware of stable Rust state because i .. don't really use stable
<qyliss^work> So what would 2018 be waiting for?
<gchristensen> waiting for it to be available in a channel :)
<edef> qyliss^work: for it to get into nixpkgs master rather than staging, for one
<qyliss^work> oh, right
<gchristensen> we need our rust toolchain to be available on the channel and functional for aarch64 darwin andlinux
<qyliss^work> Right, yeah, of course
<gchristensen> qyliss^work: for your benefit, though perhaps edef has told you
<gchristensen> btw edef I feel a lot of my Rust isn't excellent, and I'd be happy to make massive changes to its structure to make it nicer.
<gchristensen> s/edef/qyliss^work/
<gchristensen> something I mentioned a few days ago in here is I haven't really done a lot of team dev with Rust, and so most everything I've learned is through trial/error/reading/practice :)
<edef> my rust is somewhat idiosyncratic tbh
<edef> mostly because i keep myself largely to weird low-level shit and because my style has evolved along with the language over the past 8 years
<edef> current annoyance: chrono::TimeZone is used only in tests, so the lint kicks in
<edef> and errors out
<edef> i guess i can just `use chrono::prelude::*;`
<gchristensen> or just import it in the test's mod
<edef> oh i hadn't noticed you actually do that
<qyliss^work> 8 years?? wow
<qyliss^work> you are just, like, the world's earliest adopter
<edef> rust of 2010 did not resemble present-day rust much at all
<gchristensen> :think
<gchristensen> how did you get in to rust 8 years ago? :o
<edef> it was much more rubyesque in syntax
<edef> or at least, more ruby influence
<edef> and mutability was *weird* and the sigils..
<edef> you had ruby-style .each because we didn't have external iterators yet
<edef> there were like four kinds of closures
<edef> or, well, today's FnOnce + Send + 'static was a `proc` rather than something alike to regular closures
<edef> i think i just killed my kakoune trying to read 8 years of #rust logs
<qyliss^work> lmao
<edef> wait it's like. 5 years
<edef> 2013-01-16 18:03:26 +0100 --- Log opened Wed Jan 16 18:03:26 2013
<edef> but for reference, the fix i'm being instructed to use looked like `data.each |&byte| { .. }`
<gchristensen> lol what?
<edef> Vec<T> was called ~[T] and String was called ~str
<edef> and Rc<T> was called @T
<gchristensen> oh dear
<edef> and the stdlib could run against green threads on libuv
<gchristensen> yeah ... I was reading about their unfortunate flirting with green threads
<edef> you can have actually good green threads!
<gchristensen> sure
<edef> mutability was truly absurd because it was per-field, and there was uhh.. freezing
<gchristensen> not saying you can't, but building it in to the language is :|
<edef> oh and Box<T> was ~T
<gchristensen> jesus
<gchristensen> the cool thing about names is they're names :P
<edef> yes
<edef> there was also a separate notion of an exchange heap vs a task heap
<edef> but i only remember that because i had to implement the lang items for it in my kernel
<gchristensen> I don't know what that means
<edef> exchange heap was global and for Send items i think
<edef> and per-task (per-thread, but "task" was meant to cover both green threads and native threads) heaps were meant to be cheaper
<edef> gchristensen: wait why are carnix and rustfmt commented out
<edef> gchristensen: in shell.nix
<gchristensen> not sure
<gchristensen> I did some weird stuff I should have reverted back when cargo was segfaulting... probably victim of that
<edef> shall i PR that also?
<gchristensen> sure
<edef> kind of wishing i were using pijul right now because i could just cleanly prepare patches without thinking about ordering q=
<gchristensen> lol
<gchristensen> I've tried it, it was okay
<edef> the UI is awful! but the model is great
<gchristensen> yes
<edef> and now i'm forever doomed to get annoyed with git's limitations
<gchristensen> last I tried looking at it, it wasn't possible to actually build any release of it.
<gchristensen> any recent*
<edef> yeahhh
<edef> i think they fixed that
<edef> but i'm still on 0.10
<gchristensen> ah
<edef> i think Mic92 was looking into it, if memory serves right
<gchristensen> one time, I tried importing nixpkgs =)
<edef> :o
<gchristensen> it is a project I'm definitely watching
<Mic92> we have 0.11 already: https://github.com/NixOS/nixpkgs/pull/50870
<{^_^}> #50870 (by RohanHart, 2 weeks ago, merged): pijul: 0.10.0 -> 0.11.0
<gchristensen> I like that the patches aren't necessarily line-based
<Mic92> I need something like tig to be productive, which pijul is currently lacking
<Mic92> also some stuff like changing commit messages is not possible afaik.
<edef> oh neat
<{^_^}> [ofborg] @edef1c opened pull request #289 → Add non-bogus completion times to GitHub checks → https://git.io/fpH86
<{^_^}> [ofborg] @grahamc merged pull request #288 → Move @edef1c to trusted users → https://git.io/fpHGg
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fpH4k
<{^_^}> [ofborg] @grahamc merged pull request #281 → Add tilpner to extra-known-users → https://git.io/fpo3T
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fpH4L
<edef> nobody seems to actually run rustfmt on this codebase?
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fpH4t
<{^_^}> [ofborg] @grahamc merged pull request #284 → Add marsam to extra-known-users → https://git.io/fpK3z
<gchristensen> edef: was sort of waiting for rustfmt to be stable
<gchristensen> edef: little test failure -- check it out
qyliss has joined #nixos-borg
<edef> oh! will fix
<{^_^}> [ofborg] @grahamc pushed 2 commits to released: https://git.io/fpHEh
<{^_^}> [ofborg] @grahamc merged pull request #289 → Add non-bogus completion times to GitHub checks → https://git.io/fpH86
<gchristensen> deploy #100
<{^_^}> https://github.com/NixOS/nixpkgs/pull/100 (by ierton, 6 years ago, merged): Please, merge my commits
<gchristensen> lol
<gchristensen> way to go, edef
<qyliss^work> "Please, merge my commits"
<qyliss^work> lol
<gchristensen> a future thing is making the Check go through the "queued" and then "In Progress" states
<qyliss^work> that would be super useful
<edef> ok!
<edef> i will familiarise myself with more of the codebase later i think
<edef> dinner+medical first
<gchristensen> both of those things way more important
<gchristensen> heh
orivej has quit [Ping timeout: 244 seconds]
orivej has joined #nixos-borg