gchristensen changed the topic of #nixos-borg to: https://www.patreon.com/ofborg https://monitoring.nix.ci/dashboard/db/ofborg?refresh=10s&orgId=1&from=now-1h&to=now "I get to skip reviewing the PHP code and just wait until it is rewritten in something sane, like POSIX shell. || https://logs.nix.samueldr.com/nixos-borg
<infinisil> gchristensen: Would you be opposed to increasing the timeout of the builds from 1 to 2 hours?
<gchristensen> no
<infinisil> I think a lot of important builds might not timeout like that :D
<gchristensen> great! let's do it!
* infinisil searches for the PR's where he encountered this
<infinisil> gchristensen: Wait, when I do such a build for multiple attrs, is the timeout shared between all of them?
<infinisil> I guess I'll have to consult nix itself for that, you probably just run it with `nix-build -A foo -A bar --option timeout`
<gchristensen> right
<gchristensen> what does nix write to stderr on timeout?
<infinisil> gchristensen: Everything that's not a result of the evaluation
<gchristensen> specifically on timeout what does it say
<infinisil> building of '/nix/store/nhlxx4mpf9zyc3hmi8zlb50agm0q4zsj-hello.drv' timed out after 2 seconds
<gchristensen> it says something about timing out
<gchristensen> cool
<infinisil> For detecting timeouts and having a better message for ofborgs messages?
<gchristensen> infinisil: http://ix.io/1hr5
<infinisil> Ooo
<infinisil> The 30min timeout is for aarch?
<gchristensen> {"system":"x86_64-linux","identity":"builder-0-gustav.ewr1.nix.ci","attempt_id":"c360c1f6-8fc1-4440-86c1-e85ad7f303e8","attempted_attrs":["atom","samba","kodi","neomutt","vlc","afew"],"skipped_attrs":[]}
<gchristensen> hmm might have to check in to that
<gchristensen> a problem with longer builds is it takes AGES for ofborg to say it is building and the log streaming isn't very useful
<infinisil> How about changing it so that it always outputs exactly 2 messages: first for saying "I'm building these", while reporting what doesn't evaluate because of arches. Second one returning all results
<gchristensen> that is hard because there is no concept of "everything" that will be built
<gchristensen> nothing is keeping track of what is being built beyond the builder
<infinisil> I mean just the attrs you give it
<gchristensen> yeah so it'd be 2 messages posted per arch
<infinisil> Can't arches be combined?
<infinisil> Oh I bet they run on totally different machines
<gchristensen> that is hard because there is no concept of "everything" that will be built, and nothing is keeping track of what is being built beyond the builder :)
<infinisil> Ah I see now
<infinisil> Would be nice though, ofborg is quiet spammy, especially since I get an email for every message heh
<gchristensen> I do too
<gchristensen> probably better would be a web interface thing
<infinisil> gchristensen: if you had something that keeps track of builds for the messages thing, you could also use that for somehing super fancy: report a time estimate in the first message of how long the build will take, by remembering the times for previous builds :O
<gchristensen> yeah, I'd be +1 doing that as a nice-to-have but not sure I want that to be a central part of the tool
<gchristensen> in other words, I don't want a service like that which coudl break everything if it fails
<infinisil> Would be neat to have such time estimates be a nix builtin thing
<infinisil> Alright ;P
<{^_^}> ofborg#47 (by grahamc, closed): GitHub Comment Coalescing
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 244 seconds]
MichaelRaskin has quit [Quit: MichaelRaskin]
FRidh has joined #nixos-borg
orivej has joined #nixos-borg
<ekleog> gchristensen: The initial “I'm building these” message could be sent straight away from the github-comment-filter agent to the github-comment-poster just after parsing the message, though? That'd make nb_arch + 1 messages, even though it wouldn't be possible to include in the initial message “This doesn't evaluate”
<ekleog> Doesn't help for the spamminess, but does help for the “it takes AGES for ofborg to say it is building”
<gchristensen> hmmmm!!!
<gchristensen> and that could link to "logs'll be here y'all"
orivej has quit [Ping timeout: 264 seconds]
Mic92 has quit [Ping timeout: 245 seconds]
Mic92 has joined #nixos-borg
<gchristensen> man, samueldr, the logger is adding new tabs like crazy
<samueldr> looking into it now
<samueldr> https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcTaRwhYySk1oFo9Gj_9SxZuVWihq1mytLg22L4tHWliOH0wdyc5
<gchristensen> haha :D
<samueldr> any trick to find a running build?
<LnL> heh
<gchristensen> https://logs.nix.ci/?key=*.*
<samueldr> oh right, I forgot
<samueldr> to make matters worse, current builds don't seem to exhibit the issue :/
<samueldr> (I know the issue was reproducible on my browser)
<samueldr> (so it shouldn't be a case of browser differences)
<samueldr> oh, just happened
<samueldr> thankfully, it's not a total mess, only one function handles adding logs, so it shouldn't be too hard to trace the issue
orivej has joined #nixos-borg
* samueldr got it
<gchristensen> oh?
<samueldr> empty lines
<samueldr> (javascript and its weird truth table)
<samueldr> (while I do know it, it's still something that bites)
<samueldr> and you see here
<samueldr> there are empty lines
<samueldr> they would create a new log output since I checked for the absence of output
<gchristensen> ah man
<samueldr> !message.output
<samueldr> (because log starts don't have the property)
<LnL> urgh, I also dislike that about python
<gchristensen> :D
<samueldr> oh, didn't know that about python
<samueldr> ruby only has false and nil that are falsey
<LnL> empty collections like '' or [] are falsy
<samueldr> oof
<LnL> and it's used as a very common pattern
<LnL> I also don't understand why python people (at least at work) dislike ruby that much
<LnL> it's a better designed language IMHO
<samueldr> LnL: it *feels* like there are camps for python vs. ruby
<samueldr> and I also have read a TON of FUD against ruby
<samueldr> like "ruby uses so much ram"
<samueldr> when they conflated ruby and rails :/
<LnL> and they start arguments about monkey patching without realising that python stuff actually does that much more
<samueldr> (and for the record, while rails at rest takes up ram, it's hot ram, the app is ready to do stuff)
<LnL> in the ruby community there's just a shame corner for it
<samueldr> heh, monkey patching is generally frowned upon EXCEPT when the framework does it for you :)
<samueldr> (kinda like ruby was half a language SDK)
<gchristensen> oe
<samueldr> gchristensen: this should fix the tabs duplicating issue
<samueldr> though, to be fair, I never really took a seriour look at python, so I won't judge, I just have this visceral reaction agains languages where indentation matters
<samueldr> (visceral and mostly unjustified)
<gchristensen> samueldr: deployed!
<samueldr> I both like and hate how dumb the fix is
<gchristensen> :D
<samueldr> I like how it means the viewer's design isn't broken beyond repair
<gchristensen> yes
<samueldr> I hate how the language's design is broken beyond repair
<gchristensen> yes
<samueldr> (that's like my opinion, man)
<gchristensen> it won't abide, man
orivej has quit [Ping timeout: 240 seconds]
orivej has joined #nixos-borg
FRidh has quit [Quit: Konversation terminated!]
orivej has quit [Ping timeout: 240 seconds]
infinisil has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
infinisil has joined #nixos-borg
orivej has joined #nixos-borg
orivej has quit [Ping timeout: 244 seconds]