orivej has joined #nixos-borg
orivej has quit [Ping timeout: 272 seconds]
orivej has joined #nixos-borg
<
gchristensen>
ofborg should probably add labels "approved-by-maintainer" and "no-maintainer"
orivej has quit [Ping timeout: 244 seconds]
orivej has joined #nixos-borg
ekleog has quit [Quit: WeeChat 2.4]
ekleog has joined #nixos-borg
evanjs has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
evanjs has joined #nixos-borg
orivej has quit [Ping timeout: 248 seconds]
evanjs has quit [Client Quit]
evanjs has joined #nixos-borg
<
gchristensen>
what does nix-review do which ofborg does not?
<
samueldr>
what's the context to the question?
<
samueldr>
because ofborg doesn't run on my computer
<
samueldr>
doesn't directly build (a subset of) mass rebuilds
<
samueldr>
ah, I guess that's just someone taking to heart validating using nix-review
<
samueldr>
IIRC by default it even re-uses the output from ofborg to know what changed
<
gchristensen>
interesting
<
gchristensen>
oh that is right
<
samueldr>
it also does nice things like dealing with checking out in a non-obtrusive way from an existing nixpkgs checkout
orivej has joined #nixos-borg
<
timokau[m]>
Well the obvious thing is that it builds reverse-dependencies, although that doesn't really apply for the PR
evanjs has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
evanjs has joined #nixos-borg
evanjs has quit [Quit: Configuring ZNC, sorry for the joins/quits!]
evanjs has joined #nixos-borg
jtojnar has joined #nixos-borg
orivej has quit [Ping timeout: 245 seconds]