<samueldr>
to shutup shellcheck I always add a preamble of "whatever is in the derivation"
<samueldr>
so it should catch use of unbound variables I think
<samueldr>
oh, please iterate and make something better!
<LnL>
shipit
<samueldr>
just sharing that hack I tried
<samueldr>
I ran it on the linux derivation, and a couple random ones that looked bashy a bunch, and tortured myself by running it on one of mine and found issues :D
<gchristensen>
this is so good
<LnL>
one more check that would be good to add is checking if the builder is setup.sh
<LnL>
I'm not sure if this is done anywhere in nixpkgs, but in theory you can use another interpreter as the builder
<samueldr>
or do we instead want to make it obvious and "fix" it in those cases?
<LnL>
yeah wouldn't be a bad idea to discourage using a nonstandard builder in nixpkgs
<LnL>
a lot of old expressions still use their own builder, but I don't know of anything that's not bash