00:54
cransom has quit [Quit: WeeChat 2.1]
01:31
<
gchristensen >
what if
01:31
<
gchristensen >
to get the maintainers of changed packages
01:31
<
gchristensen >
I get the list of attributes changed
01:31
<
gchristensen >
use unsafeGetAttrPos or whatever to get the file it came from
01:31
<
gchristensen >
and see if that file is in the diff
01:32
<
gchristensen >
I'm a few beers in so maybe that isn't a good idea
01:33
<
samueldr >
that's because mapping changedFile to changedAttribute is harder, right?
01:33
<
gchristensen >
yeah
01:34
<
gchristensen >
I think?
01:34
<
gchristensen >
I have no idea how to do that
01:34
<
samueldr >
you don't want to ping the whole world on a coreutils change
01:34
<
gchristensen >
exactly
01:56
<
gchristensen >
I should write nix code a few beers in more often apparently
01:56
<
samueldr >
your liver and bosses may not approve ;)
02:05
<
gchristensen >
ah ha!
02:06
<
{^_^} >
#45195 (by Ralith, 2 weeks ago, merged): vulkan: 1.1.77.0 -> 1.1.82.1
02:15
<
gchristensen >
guh I think it could work
02:16
<
samueldr >
it probably can!
02:16
<
samueldr >
try it with fun PRs :)
02:16
<
gchristensen >
links to examples?
02:16
<
samueldr >
ideally, you want to have false negatives, and not false positives (miss maintainers than ping wrong ones)
02:16
<
gchristensen >
yeah definitely
02:16
<
samueldr >
none! I thought you would know
02:17
<
gchristensen >
hehe
02:17
<
gchristensen >
I'll try it on some.
02:17
<
gchristensen >
maybe "dark"-launch it
02:25
<
gchristensen >
this is too powerful.
02:28
<
samueldr >
I'm not sure I like your scheming tone... "dark", "too powerful"
02:28
<
samueldr >
are you turning into a villain?
02:29
<
gchristensen >
turning?
02:31
<
samueldr >
you know what happens to all(?) villains?
02:31
<
samueldr >
they do a dumb mistake that an bumbling idiot "hero" profits of to turn the tides ;)
02:49
<
gchristensen >
samueldr: want to try it?
02:50
<
samueldr >
defeating you?
02:54
<
gchristensen >
samueldr: want to try the script?
02:55
<
samueldr >
yeah, if you have something ready
02:55
<
gchristensen >
save this at ./nixpkgs/pr-maintainers.sh
02:55
<
gchristensen >
chmod +x ...
02:55
<
samueldr >
that .sh is... sneaky
02:55
<
gchristensen >
./pr-maintainers.sh 45912
02:56
<
gchristensen >
it really needs to be run in a checkout matching the PR so it'll sometimes fail, but ... :)
02:57
<
samueldr >
I may integrate something like that in my review script :)
02:57
<
samueldr >
(I already diff attributes, so I don't even need to check github)
02:58
<
gchristensen >
well
02:58
<
gchristensen >
sure
02:58
<
gchristensen >
I was thinking I might add it to ofborg this weekend :)
02:59
<
{^_^} >
#43680 (by leo60228, 6 weeks ago, open): msbuild: init at 15.6
02:59
<
samueldr >
(just in case you wanted to know)
02:59
<
gchristensen >
I'm getting a lot of assertion errors :( + nix-instantiate --eval ./data.nix
02:59
<
gchristensen >
error: Linux v4.18.2018.08.31 is not yet supported by zfsonlinux v0.7.9.
02:59
<
gchristensen >
Try zfsUnstable or set the NixOS option boot.zfs.enableUnstable.
03:00
<
samueldr >
(I'm not on their head, I'm on their head merged into nixpkgs-unstable though)
03:00
<
gchristensen >
I think this + outpaths.nix in ofborg/ofborg/src could work
03:01
<
gchristensen >
anyway, long past bed time.
03:01
<
gchristensen >
g'night :)
03:01
<
gchristensen >
lol <3
03:17
cransom has joined #nixos-borg
07:40
orivej has joined #nixos-borg
10:04
<
LnL >
gchristensen: there are a few edgecases that wouldn't be detected
10:05
<
LnL >
nix edit uses meta.destription with a fallback to name to find stuff, but if there's a generic.nix with variants there might only be changes in ./x.y.nix
10:20
jtojnar has quit [Quit: jtojnar]
10:29
jtojnar has joined #nixos-borg
11:15
<
gchristensen >
LnL: true. is there a way to "fix" those?
11:16
<
LnL >
not that I can think of
11:16
<
LnL >
but those are not false positives, so might be ok
11:17
<
gchristensen >
maybe, unfortunately, duplicating the maintainer fields out to the generic
11:21
<
LnL >
yeah, duplicating meta is a relatively sane workaround
11:21
<
LnL >
and that also fixe nix edit
11:21
<
gchristensen >
yeah
11:26
<
{^_^} >
#45468 (by dtzWill, 1 week ago, merged): boost168: init
11:26
<
{^_^} >
#45468 (by dtzWill, 1 week ago, merged): boost168: init
11:27
<
LnL >
yeah, but that also changed generic.nix
11:31
<
gchristensen >
before my diff it didn't find any maintainers
11:32
<
gchristensen >
oh, it didn't modify generic.nix
11:32
<
gchristensen >
pkgs/development/libraries/boost/1.68.nix and pkgs/top-level/all-packages.nix
11:33
<
LnL >
oh, that's not the diff from the pr
11:33
<
gchristensen >
yeah, if we changed boost's definition to be like that, then the PR would have been correctly detected
12:08
<
LnL >
does your thing follow maintainers, or description like nix?
12:28
jtojnar has quit [Read error: Connection reset by peer]
12:28
jtojnar has joined #nixos-borg
12:32
<
gchristensen >
maintainers
13:01
<
LnL >
I think I might have simplified this problem a bit in my head
13:02
<
LnL >
doesn't moving meta break the reverse?
13:02
<
LnL >
changing only generic should also ping maintainers
14:32
orivej has quit [Ping timeout: 245 seconds]
14:45
jtojnar has quit [Remote host closed the connection]
14:47
jtojnar has joined #nixos-borg
14:48
WilliButz has quit [Ping timeout: 272 seconds]
14:49
WilliButz has joined #nixos-borg
17:43
<
gchristensen >
LnL: heh, true
17:44
<
gchristensen >
LnL: maybe I should look at many fields, version, pname, src, meta
17:55
<
LnL >
yeah, that would work for this usecase
18:48
<
gchristensen >
ok VERY weird thing
18:49
<
{^_^} >
#45635 (by matthewbauer, 1 week ago, open): mesa: remove darwin-specific derivations
18:49
<
gchristensen >
oh it was deleted a few days ago
18:56
<
LnL >
cbdcf6b4db2e94438fcb54a7394fa31e31502faf
18:57
<
LnL >
git log -G is pretty useful for this kind of stuff
18:58
<
gchristensen >
nice
18:58
<
gchristensen >
I use -S sually
18:59
<
LnL >
ah, it's basically the same
18:59
<
gchristensen >
I really really really want an indexed database of all of a git log
18:59
<
gchristensen >
like Hound, but history-aware
18:59
<
LnL >
that would be
__amazing__
19:00
<
LnL >
the fact that hound only indexes on branch has also bitten me a few times
19:00
<
samueldr >
even more so if it's in a workable format to somehow link it with more data (e.g. local cache of github PRs)
19:00
<
gchristensen >
is github ... down?
19:00
<
gchristensen >
like I can't even connect, and when I do I get 500's
19:01
<
samueldr >
seems up here
19:01
<
gchristensen >
ok. weird.
19:01
<
gchristensen >
I guess it is time to go to the store then :)
19:23
orivej has joined #nixos-borg
20:08
orivej has quit [Ping timeout: 240 seconds]
20:43
cransom has quit [Ping timeout: 252 seconds]
20:53
cransom has joined #nixos-borg
21:27
cransom has quit [Quit: WeeChat 2.1]
21:35
cransom has joined #nixos-borg
21:36
timokau[m] has joined #nixos-borg
21:47
<
gchristensen >
damn
21:47
<
gchristensen >
I can't look at the `name` attribute because it is always in /home/grahamc/projects/nixpkgs/pkgs/stdenv/generic/make-derivation.nix
21:47
<
gchristensen >
# A hack to make `nix-env -qa` and `nix search` ignore broken packages.
21:47
<
gchristensen >
# TODO(@oxij): remove this assert when something like NixOS/nix#1771 gets merged into nix.
21:47
<
gchristensen >
name = assert validity.handled; name + lib.optionalString
21:48
<
LnL >
yeah, that's why edit tries the description first
22:41
<
gchristensen >
I think it works really well
22:42
<
gchristensen >
it is super ugly as-is but only because I wanted it to be easy to run and share as a shell script while I hacked on it :)
22:44
<
gchristensen >
shockingly it correctly detected a mass-rebuild (bison) had no maintainer
22:44
<
gchristensen >
so ... I think that is good ... :D
22:55
<
LnL >
yeah, overlaying meta.maintainers with the diff should be a pretty good heuristic
22:55
<
gchristensen >
I'm scared of some scary condition where I ping 200 people
22:55
<
LnL >
btw. I wonder if wouldn't be better to put this and the rebuild expression in nixpkgs
22:56
<
LnL >
what ofborg uses now is kind of hidden
22:56
<
gchristensen >
yeah
22:56
<
gchristensen >
the reason I didn't is I don't trust the PR's nixpkgs... but maybe I could just point to a trusted revision.
22:57
<
LnL >
oh yeah, we can keep it duplicated in the repo
22:58
<
LnL >
or use the one from the deploy nixpkgs or something
22:58
<
gchristensen >
yeah
22:58
<
gchristensen >
fetchurl :)