00:53 <shlevy> gchristensen: IMO for the installer itself just getting a +1 from someone on the team should be good. Until the release process is solidified, though, I'd ping him for backports

00:54 <shlevy> (I haven't reviewed that one myself because I'm too close to its implementation and use case ;) )

00:54 <gchristensen> :)

00:55 <gchristensen> shlevy: how do you like the new version of this PRV https://github.com/NixOS/nix/pull/2037

00:55 <gchristensen> PR*

01:00 <shlevy> gchristensen: Hmm... I think this definitely belongs in build-remote.cc instead. Setting aside separation of concerns, in this PR you lose the "but I am a <foo>" message... It's no longer clear if the build failed because you have no remotes at all, or because you lack the right system, or because you lack the right features. That information is all available in build-remote's context.

01:00 <gchristensen> interesting

01:00 <gchristensen> can you point me to where it would make sense in there?

01:02 <shlevy> So here's where we loop through machines https://github.com/NixOS/nix/blob/1df32c7d7c5ce0a4d10fa1e13f557ff525a62efa/src/build-remote/build-remote.cc#L117

01:03 <shlevy> And at the end we message with "decline" if we haven't found one

01:03 <gchristensen> oohh

01:03 <shlevy> We could add a bool to check if a machine of the right system but wrong features was found, if we wanted

01:03 <gchristensen> then we can actually emit logs per machine

01:03 <shlevy> Yeah

01:03 <gchristensen> I've always wanted that

01:03 <shlevy> In a verbose mode

01:03 <gchristensen> naturally

01:04 <gchristensen> cool, thanks!